Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] mail_notification_custom_subject #1454

Open
wants to merge 24 commits into
base: 16.0
Choose a base branch
from

Conversation

edlopen
Copy link
Member

@edlopen edlopen commented Oct 1, 2024

Standard migration to v16.

@moduon MT-7401

@Shide @yajo @EmilioPascual @rafaelbn please review, if you can.

joao-p-marques and others added 24 commits October 1, 2024 12:57
…l notifications

This module allows you to specify templates to override the subject on the notification
emails sent by Odoo.

TT27191

Co-authored-by: Pedro M. Baeza <[email protected]>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: social-15.0/social-15.0-mail_notification_custom_subject
Translate-URL: https://translation.odoo-community.org/projects/social-15-0/social-15-0-mail_notification_custom_subject/
… send messages

After installing the module, any user was required to have admin rights to be able to search across models.

This fix does just that search with sudo and returns back to non-sudo mode immediately after. This way, we don't need to increase permissions for everybody.

Tests now run unprivileged, to assert this problem never happens again.

@moduon MT-1644 MT-1645
Currently translated at 100.0% (21 of 21 strings)

Translation: social-15.0/social-15.0-mail_notification_custom_subject
Translate-URL: https://translation.odoo-community.org/projects/social-15-0/social-15-0-mail_notification_custom_subject/es/
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

Copy link

@EmilioPascual EmilioPascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review code

@pedrobaeza pedrobaeza changed the title 16.0 mig mail notification custom subject [16.0][MIG] mail_notification_custom_subject Oct 2, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split the pre-commit changes from the migration itself as stated in the migration guide

/ocabot migration mail_notification_custom_subject

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 2, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 2, 2024
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.