Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [MIG] mail_attach_existing_attachment #976

Merged
merged 20 commits into from
Jan 19, 2023
Merged

[16.0] [MIG] mail_attach_existing_attachment #976

merged 20 commits into from
Jan 19, 2023

Conversation

baimont
Copy link
Contributor

@baimont baimont commented Oct 3, 2022

@oca-clabot
Copy link

Hey @baimont, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@baimont baimont force-pushed the 16.0-mig-mail_attach_existing_attachment-bai branch from 090d736 to c0ed8a2 Compare October 3, 2022 08:30
@sbidoul
Copy link
Member

sbidoul commented Oct 3, 2022

/ocabot migration mail_attach_existing_attachment

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 3, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 3, 2022
Open
38 tasks
adrienpeiffer and others added 19 commits January 19, 2023 12:02
@adrienpeiffer @baimont
[IMP][mail_attach_existing_attachment] Change module name
b90ac33
@sergio-teruel @baimont
[MIG][9.0] mail_attach_existing_attachment: Module migrated (OCA#68)
3db0d8a 
* [MIG][9.0] mail_attach_existing_attachment: Module migrated
@bouvyd @baimont
[MIG] mail_attach_existing_attachment: Migrated to 10.0
a1f30a1
@ernestotejeda @baimont
[MIG] mail_attach_existing_attachment: Migration to 11.0
1d32187
@ernestotejeda @baimont
[MIG] mail_attach_existing_attachment: Migration to 12.0
911fcdb
@baimont
Translated using Weblate (Portuguese (Brazil))
b44c4e1 
Currently translated at 100.0% (3 of 3 strings)

Translation: social-12.0/social-12.0-mail_attach_existing_attachment
Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_attach_existing_attachment/pt_BR/
@sysadminmatmoz @baimont
Translated using Weblate (Slovenian)
f348dec 
Currently translated at 100.0% (3 of 3 strings)

Translation: social-12.0/social-12.0-mail_attach_existing_attachment
Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_attach_existing_attachment/sl/
@bealdav @baimont
FIX image display
c7adfba
@Rad0van @baimont
[IMP] mail_attach_existing_attachment: black, isort, prettier
e46a653
@Rad0van @baimont
[MIG] mail_attach_existing_attachment: Migration to 13.0
ba7301e
@ygol @baimont
Added translation using Weblate (Hebrew)
47a63d5
@baimont
[IMP] pre-commit run -a
54ba21b
@baimont
[MIG] mail_attach_existing_attachment: Migration to 14.0
5d0db19
@oca-travis @baimont
[UPD] Update mail_attach_existing_attachment.pot
0541b9b
@oca-travis @baimont
[UPD] Update mail_attach_existing_attachment.pot
4e6ecbf
@oca-transbot @baimont
Update translation files
a966c89 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: social-14.0/social-14.0-mail_attach_existing_attachment
Translate-URL: https://translation.odoo-community.org/projects/social-14-0/social-14-0-mail_attach_existing_attachment/
@AlvarTB @baimont
[15.0][MIG]mail_attach_existing_attachment: module migration fron 14.…
f9ad1c0 
…0 to 15.0
@baimont
[UPD] Update mail_attach_existing_attachment.pot
1d16d7f
@OCA-git-bot @baimont
[UPD] README.rst
5658d7c
@baimont baimont force-pushed the 16.0-mig-mail_attach_existing_attachment-bai branch from c0ed8a2 to db7888d Compare January 19, 2023 11:03
xavier-bouquiaux
xavier-bouquiaux approved these changes Jan 19, 2023
View reviewed changes
Copy link

@xavier-bouquiaux xavier-bouquiaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tech review

xavier-bouquiaux
xavier-bouquiaux reviewed Jan 19, 2023
View reviewed changes
mail_attach_existing_attachment/readme/CONTRIBUTORS.rst Show resolved Hide resolved
mail_attach_existing_attachment/readme/ROADMAP.rst
@@ -0,0 +1 @@
* The module only allows the addition of attachments linked to the object.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking : shouldn't be in this file (it's more a description)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in my sense it should stay there because the word "only" refers to a limitation that could be address in the future

mail_attach_existing_attachment/tests/test_mail_attach_existing_attachment.py Outdated Show resolved Hide resolved
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@xavier-bouquiaux
Copy link

Functionnal review : screen design could be optimized

I'll open an issue

@baimont baimont force-pushed the 16.0-mig-mail_attach_existing_attachment-bai branch from db7888d to c4bd2b4 Compare January 19, 2023 11:18
@baimont
Copy link
Contributor Author

baimont commented Jan 19, 2023

Functionnal review : screen design could be optimized I'll open an issue

I agree with you

sbejaoui
sbejaoui approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@sbejaoui sbejaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review

@sbidoul
Copy link
Member

sbidoul commented Jan 19, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-976-by-sbidoul-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d2991ee into OCA:16.0 Jan 19, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 18e40c3. Thanks a lot for contributing to OCA. ❤️

@sbidoul sbidoul deleted the 16.0-mig-mail_attach_existing_attachment-bai branch January 19, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavier-bouquiaux xavier-bouquiaux xavier-bouquiaux approved these changes

@dreispt dreispt dreispt approved these changes

@sbejaoui sbejaoui sbejaoui approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.