Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui(dropdown menu): Added DropdownMenu component in ui-next #4387

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

dan-rukas
Copy link
Member

@dan-rukas dan-rukas commented Sep 25, 2024

Context

Adds the DropdownMenu reusable component with styles matching the Select component.

Changes & Results

DropdownMenu component available in ui-next

Screenshot 2024-09-27 at 11 29 50 AM

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for ohif-dev canceled.

Name Link
🔨 Latest commit e3cb3d2
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/66f6d36b63cc9d00081eb900

Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for ohif-platform-docs canceled.

Name Link
🔨 Latest commit e3cb3d2
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/66f6d36b547b0700088033c5

Copy link

cypress bot commented Sep 25, 2024

Viewers    Run #4299

Run Properties:  status check failed Failed #4299  •  git commit e3cb3d2071: update
Project Viewers
Branch Review feat/menu-design
Run status status check failed Failed #4299
Run duration 02m 34s
Commit git commit e3cb3d2071: update
Committer Alireza
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 8
Tests that passed  Passing 35
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/integration/study-list/OHIFStudyList.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Study List > Desktop resolution > Displays several studies initially Test Replay Screenshots Video

@sedghi sedghi changed the title component(ui): Added DropdownMenu component in ui-next ui(dropdown menu): Added DropdownMenu component in ui-next Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants