-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transform: luaxform transform script #11817
Conversation
This commit makes the detection engine thread context available for transforms to use. The Lua transform requires this value. Issue: 2290
Issue: 2290 This commit extends the hash table logic with an alternate free function that provides the detection engine context. Users that wish to use the next functionality must use the HashListTableInitWithCtx function when initializing the hash table. Using this interface will result in the hash table "free with context" function (new) being used instead.
Issue: 2290 This commit causes the keyword_hash pointer to be cleared after it's been freed.
Issue: 2290 This commit adds the source files for the new transform -- luaxform.
Issue: 2290
Issue: 2290 Fixup the macro usage to eliminate compiler warnings.
static void DetectTransformLuaxformFree(DetectEngineCtx *de_ctx, void *ptr); | ||
static void TransformLuaxform(InspectionBuffer *buffer, void *options); | ||
|
||
void DetectTransformLuaxformRegister(void) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this file be in rust ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no reason why it couldn't; I chose C since the majority of transforms are expressed in C.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opening a new PR with a transform in rust soon ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#11861 ;-)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11817 +/- ##
==========================================
- Coverage 82.58% 79.00% -3.58%
==========================================
Files 914 917 +3
Lines 249500 249562 +62
==========================================
- Hits 206045 197169 -8876
- Misses 43455 52393 +8938
Flags with carried forward coverage won't be shown. Click here to find out more. |
WARNING:
Pipeline 22858 |
Continued in #11860 |
Continuation of #11733
Add the
luaxform
transform that uses a Lua script to receive and transform a sticky buffer.Lua transforms receive arguments
Arguments are passed to the lua script as they appear in the rule:
When the transform is invoked, 3 additional arguments are passed (arg count will be 3)
bytes 4
offset 13
hash sha256
The Lua script is responsible for parsing and using the arguments and returning a tuple:
output-buffer, output-buffer-byte-count
I used this lua script:
Example rule using the lua script:
Link to ticket: https://redmine.openinfosecfoundation.org/issues/2290
Describe changes:
Updates
Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCH
variable.SV_REPO=
SV_BRANCH=OISF/suricata-verify#2044
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=