[detect] allow rule which need both directions to match 5665 v19 #11900
+345
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11900 +/- ##
==========================================
+ Coverage 82.60% 82.62% +0.01%
==========================================
Files 912 912
Lines 249342 249515 +173
==========================================
+ Hits 205968 206157 +189
+ Misses 43374 43358 -16
Flags with carried forward coverage won't be shown. Click here to find out more. |
Ticket: 5665 This is done with `alert ip any any => any any` The => operator means that we will need both directions
catenacyber
force-pushed
the
detect-bidir-5665-v19
branch
from
182efd9
to
4fec5a5
Compare
|
Ongoing questions :
|
|
Information: QA ran without warnings. Pipeline 23074 |
catenacyber
requested review from
jufajardini and
victorjulien
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5665
Describe changes:
SV_BRANCH=OISF/suricata-verify#2083
#11578 with review taken into consideration in last commit +
only_tc)SIG_FLAG_INIT_BIDIR_FAST_TOCLIENTto check before setting `SIG_FLAG_INIT_BIDIR_STREAMING_TOSERVER