Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL: parser v2 #11996

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

QianKaiLin
Copy link

@QianKaiLin QianKaiLin commented Oct 21, 2024

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Our Contribution agreements:

Changes (if applicable):

  • I have updated the User Guide (in doc/userguide/) to reflect the changes made
  • I have updated the JSON schema (in etc/schema.json) to reflect all logging changes
    (including schema descriptions)

Link to ticket: https://redmine.openinfosecfoundation.org/issues/3446

Describe changes:

  • fix mysql parser bug.
  • fix mysql logger bug.
  • add mysql detection keywords mysql.command and mysql.rows
  • add SV tests.
  • upgrade User Guide document and Upgrade document.

SV_BRANCH=OISF/suricata-verify#2067

Copy link

NOTE: This PR may contain new authors.

Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please take a look at all the CI failures, fix them and resubmit?
Thank you!

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 29.73684% with 1602 lines in your changes missing coverage. Please review.

Project coverage is 79.23%. Comparing base (55b922c) to head (d9d6032).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11996      +/-   ##
==========================================
- Coverage   82.75%   79.23%   -3.53%     
==========================================
  Files         910      914       +4     
  Lines      249016   260285   +11269     
==========================================
+ Hits       206069   206224     +155     
- Misses      42947    54061   +11114     
Flag Coverage Δ
fuzzcorpus 60.76% <4.34%> (-0.05%) ⬇️
livemode 19.19% <4.44%> (+0.48%) ⬆️
pcap 43.87% <4.06%> (-0.26%) ⬇️
suricata-verify ?
unittests 59.02% <29.64%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@QianKaiLin
Copy link
Author

Could you please take a look at all the CI failures, fix them and resubmit? Thank you!

Yeah, I will fix it.

@jufajardini
Copy link
Contributor

I've re-authorized the CI checks. As a reminder, before the work can be merged, commits that just fix changes introduced by this PR should be squashed into their related original commits ;)

@Kotodian Kotodian force-pushed the dev-3346-mysql-proto-v2 branch 2 times, most recently from 31b0f50 to dd199a4 Compare October 26, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants