-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MySQL: parser v2 #11996
base: master
Are you sure you want to change the base?
MySQL: parser v2 #11996
Conversation
beba425
to
9bfc934
Compare
NOTE: This PR may contain new authors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please take a look at all the CI failures, fix them and resubmit?
Thank you!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11996 +/- ##
==========================================
- Coverage 82.75% 79.23% -3.53%
==========================================
Files 910 914 +4
Lines 249016 260285 +11269
==========================================
+ Hits 206069 206224 +155
- Misses 42947 54061 +11114
Flags with carried forward coverage won't be shown. Click here to find out more. |
Yeah, I will fix it. |
I've re-authorized the CI checks. As a reminder, before the work can be merged, commits that just fix changes introduced by this PR should be squashed into their related original commits ;) |
31b0f50
to
dd199a4
Compare
dd199a4
to
46feb19
Compare
46feb19
to
5740d0c
Compare
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
Link to ticket: https://redmine.openinfosecfoundation.org/issues/3446
Describe changes:
mysql.command
andmysql.rows
SV_BRANCH=OISF/suricata-verify#2067