Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI: Fixed unused 'wizard' variable - F841 in image2target/ #4400

Merged
merged 7 commits into from
Oct 1, 2024

Conversation

arohanajit
Copy link
Contributor

Since wizard isn't being used anywhere, it looks like it's only purpose is to trigger GCPWizard constructor. However, instead of deleting it, I've just commented it our rn incase it needs to be used in future (just as a previous version of it was) - which I'll remove if need be.
I'm triggering the constrcutor standalone without any variable which fixes F841

@github-actions github-actions bot added GUI wxGUI related Python Related code is in Python labels Sep 27, 2024
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just remove it, no need to keep it commented.

echoix
echoix previously approved these changes Sep 27, 2024
echoix
echoix previously approved these changes Sep 30, 2024
@echoix echoix dismissed petrasovaa’s stale review September 30, 2024 17:40

Code was removed as requested

@echoix echoix enabled auto-merge (squash) September 30, 2024 17:40
auto-merge was automatically disabled October 1, 2024 15:49

Head branch was pushed to by a user without write access

@petrasovaa petrasovaa added this to the 8.5.0 milestone Oct 1, 2024
@petrasovaa petrasovaa merged commit 13cda73 into OSGeo:main Oct 1, 2024
26 of 47 checks passed
@arohanajit arohanajit deleted the image2target-f841 branch October 1, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI wxGUI related Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants