Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: add usage explanations #4421

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

neteler
Copy link
Member

@neteler neteler commented Sep 30, 2024

Explain how to use the docker images.

Rationale: the web site (https://grass.osgeo.org/download/docker/) does not contain any usage info (see also OSGeo/grass-website#470). My goal is to be less nerdy and lower the barrier to using our docker images.

Explain how to use the docker images.
May then be linked to at https://grass.osgeo.org/download/docker/
@neteler neteler added the docker Docker related label Sep 30, 2024
@neteler neteler added this to the 8.5.0 milestone Sep 30, 2024
@neteler neteler self-assigned this Sep 30, 2024
@neteler neteler added the backport to 8.4 PR needs to be backported to release branch 8.4 label Sep 30, 2024
@neteler
Copy link
Member Author

neteler commented Sep 30, 2024

Question: keep "8.4." also in main?

@github-actions github-actions bot added the docs label Sep 30, 2024
Comment on lines +92 to +96
```bash
docker run -it --rm -e DISPLAY=$DISPLAY \
-v /tmp/.X11-unix:/tmp/.X11-unix \
osgeo/grass-gis:releasebranch_8_4-ubuntu_wxgui grass
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it clear that it won't work for windows (when not running through a WSL)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may add Windows usage instructions (I'd rely on others to suggest them).

Comment on lines +103 to +105
```bash
docker run -it --rm -v "$(pwd):/data" osgeo/grass-gis:releasebranch_8_4-alpine grass
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't work with Windows cmd.exe, might work with powershell (pwsh).

docker/README.md Outdated
# GRASS GIS docker

## GRASS GIS docker matrix
## GRASS GIS 8.4 (current) Docker installation and usage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to not have to change this too when changing versions?

Copy link
Member

@wenzeslaus wenzeslaus Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, including a version anywhere (including the code examples below) slows the release process (here specifically the branching) adding time which at this point a human needs to spend.

Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you tell us more what you are aiming at with this PR? The main readme has some info one running Docker images. Perhaps here, we need more info for the maintainers?

Comment on lines +58 to +62
**Running:**

```bash
docker run -it --rm osgeo/grass-gis:releasebranch_8_4-debian grass -c EPSG:4326 /tmp/grassproject
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same for every image except for the tag. Too much stuff to read and maintain. Is there an example how other projects are addressing that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker/README.md Outdated Show resolved Hide resolved
@@ -25,4 +24,119 @@ the table above):
docker pull osgeo/grass-gis:<tag>
```

## Provided images
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why to have a list of images here? They are on the Docker hub and the website. This looks like user-facing doc, which is exactly what Docker hub and website are trying to cover, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I did not remember that it is also in the main README. I simply looked next to Docker.

@neteler
Copy link
Member Author

neteler commented Sep 30, 2024

Can you tell us more what you are aiming at with this PR?

Sure: I tried to implement your suggestion: OSGeo/grass-website#470 (comment)

Rationale: the web site (https://grass.osgeo.org/download/docker/) does not contain any usage info. My goal is to be less nerdy and lower the barrier to using our docker images.

@neteler
Copy link
Member Author

neteler commented Sep 30, 2024

The main readme has some info one running Docker images.

I would reduce it there and point to this README.
Mhh, probably then it would not be visible any more on https://hub.docker.com/r/osgeo/grass-gis/ ...

@neteler neteler marked this pull request as draft October 1, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to 8.4 PR needs to be backported to release branch 8.4 docker Docker related docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants