Common file.c util leaks
#1661
Open
Common file.c util leaks
#1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `file_read` allocates memory, it should be free-ed. Currently, attempting to do so will cause a compiler warning since `free` does not take `const` qualified pointer (because we are modifying the memory). Changing the return type to `char *` rather than `const char *` will allow the caller to correctly free memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
file_readallocates memory, it should be free-ed. Currently,attempting to do so will cause a compiler warning since
freedoesnot take
constqualified pointer (because we are modifying thememory).
Changing the return type to
char *rather thanconst char *willallow the caller to correctly free memory.
Also fix most of the transitive leaks I could find. e.x.
strdupreturns allocated memory that should be free-ed.Last patch doesn't really fix anything but adds the
mallocfunction attribute for the compiler but also to hint to developers that the function allocates memory that needs to be free-ed.