Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify inject status "SUCCESS" #1607

Closed
jborozco opened this issue Oct 2, 2024 · 1 comment · Fixed by #1792 or OpenBAS-Platform/implant#14
Closed

Clarify inject status "SUCCESS" #1607

jborozco opened this issue Oct 2, 2024 · 1 comment · Fixed by #1792 or OpenBAS-Platform/implant#14
Assignees
@MarineLeM
Labels
bug use for describing something not working as expected solved The issue has been solved
Milestone
Release 1.9.0

Comments

@jborozco
Copy link

jborozco commented Oct 2, 2024

Use case

At inject level, the status "success" in the traces is not well understood:

  • Success means that the inject has been correctly executed, but success is also a status of expectation which make the whole thing confusing.
  • An inject is considered as success if the exit_code = 0 but it doesn't cover cases such as invalid syntax
    image

Proposed Solution

  • Rename in traces the status "SUCCESS" to "EXECUTED"
  • Change the logic of this status to cover edge cases, if the inject is not fully executed the status should be "PARTIAL"
  • improve status MAY BE PREVENTED logic as well ? TBD
@jborozco jborozco added feature use for describing a new feature to develop needs triage use to identify issue needing triage from Filigran Product team and removed needs triage use to identify issue needing triage from Filigran Product team labels Oct 2, 2024
@jborozco jborozco added this to the Release 1.10.0 milestone Oct 2, 2024
@RomuDeuxfois
Copy link
Member

Linked to this OpenBAS-Platform/implant#10

@jborozco jborozco self-assigned this Oct 3, 2024
@EllynBsc EllynBsc added bug use for describing something not working as expected and removed feature use for describing a new feature to develop labels Oct 24, 2024
@MarineLeM MarineLeM self-assigned this Oct 24, 2024
This was referenced Oct 31, 2024
Merged
Merged
@MarineLeM MarineLeM linked a pull request Oct 31, 2024 that will close this issue
[implant] improve trace status OpenBAS-Platform/implant#14
Merged
@MarineLeM MarineLeM mentioned this issue Nov 4, 2024
Closed
MarineLeM added a commit that referenced this issue Nov 6, 2024
@MarineLeM
[backend] fix inject status after execution (#1607)
c7ec1d2
@RomuDeuxfois RomuDeuxfois added the solved The issue has been solved label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarineLeM MarineLeM

Labels
bug use for describing something not working as expected solved The issue has been solved
Projects
None yet
Milestone
Release 1.9.0
4 participants
@MarineLeM @EllynBsc @jborozco @RomuDeuxfois