Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] fix inject status after execution #1792

Merged
merged 3 commits into from
Nov 6, 2024
Merged

[backend] fix inject status after execution #1792

merged 3 commits into from
Nov 6, 2024

Conversation

MarineLeM
Copy link
Contributor

Context

Close: #1607
PR linked to this implant PR : OpenBAS-Platform/implant#14

Explanation :

On the implant i had new trace status ( WARNING, COMMAND_NOT_FOUND and COMMAND_CANNOT_BE_EXECUTED)
So in this api I have to handle it

The inject status can be

  • SUCCESS => if all the status traces of the inject is SUCCESS or WARNING
  • ERROR => if all the status traces of the inject is ERROR or COMMAND_NOT_FOUND
  • PARTIAL => if at least on status traces of the inject is SUCCESS or WARNING
  • MAYBE_PREVENTED => if all the status traces of the inject is MAYBE_PREVENTED or COMMAND_CANNOT_BE_EXECUTED
  • other the status will be MAYBE_PARTIAL_PREVENTED

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 32.06%. Comparing base (1ff9f9e) to head (c5c8d34).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...rc/main/java/io/openbas/rest/inject/InjectApi.java 0.00% 19 Missing ⚠️
...nbas/injectors/openbas/OpenBASImplantExecutor.java 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1792      +/-   ##
============================================
- Coverage     32.08%   32.06%   -0.02%     
+ Complexity     1609     1608       -1     
============================================
  Files           561      561              
  Lines         16850    16856       +6     
  Branches        974      984      +10     
============================================
- Hits           5406     5405       -1     
- Misses        11200    11206       +6     
- Partials        244      245       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarineLeM MarineLeM self-assigned this Oct 31, 2024
@MarineLeM MarineLeM merged commit c7ec1d2 into master Nov 6, 2024
6 checks passed
@MarineLeM MarineLeM deleted the issue/1607 branch November 6, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify inject status "SUCCESS"
2 participants