Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(log-sorting): ability to sort logs based on start date [Issue #110] #151

Merged
merged 10 commits into from
Nov 10, 2024

Conversation

mellodev
Copy link
Contributor

@mellodev mellodev commented Nov 7, 2024

Proposed Changes

  • Github issue Log sorting #110 requests the ability to sort the event log table by start date rather than end date
  • Add dependency for grid component DataTables.net which allows easy jQuery based sorting, searching and filter of plain HTML tables
  • Including this dep sets the project up to easily extend functionality of any existing table.
  • Change ordering and presentation of Logs table columns to include Start Time and End Time
  • ⚠️ DataTables component has an MIT license, do we need to provide attribution somewhere since we will be include their distributables in the repo?

Demo Video

opensprinkler.110.mp4

@salbahra
Copy link
Member

Looks great, we keep our open source libraries listed on this wiki: https://github.com/OpenSprinkler/OpenSprinkler-App/wiki/List-of-Integrated-Libraries. I believe you might have access to edit but if not once I release this I will add it to the wiki.

Thank you very much, this looks great!

@salbahra salbahra merged commit 1d87957 into OpenSprinkler:master Nov 10, 2024
1 check passed
@salbahra salbahra mentioned this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants