Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add length of message to duplicate message detection (addresses #2587) #2589

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add length of message to duplicate message detection (addresses #2587) #2589

wants to merge 1 commit into from

Conversation

rrozema
Copy link
Contributor

@rrozema rrozema commented Feb 22, 2021

As described in issue #2587 a duplicate message may fail to be detected because additional bytes from previous messages are included in the comparison. This PR tries to address this by adding the length of a previously received message in the nod structure and use it in the comparison for a new incoming message. Also added setting the remainder of the buffer to 0x00 to make it more clear which data was actually in the buffer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant