User alerts; level/color start/stop events; set_log_file_path() #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set_log_file_path()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is dependent on PR #2531 in OpenZWave/open-zwave, which adds support for setting the log file path.
This change is necessary to fully support the RGBGenie, a switch that sends various light control commands.
The PR adds three enhancements:
Support receiving user alerts (such as alerts about failures to update the config, etc.). Turns them into notifications.
Support receiving level change and color change start/stop events. A switch can send commands to start incrementally changing the level (for dimming) or the color (for hue adjustment).
Support setting the log file path with set_log_file_path(). This can be used to move the log file to, e.g., /var/tmp (or somewhere else) if you need to not be writing in the current location.