feat(api): Allow recovering from errors that happen during the preparation part of an aspirate command #16896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
reviewed
Nov 20, 2024
| if isinstance(move_result, DefinedErrorData): | ||
| return DefinedErrorData(move_result.public, state_update=state_update) | ||
|
|
||
| # TODO: Figure out what to do for state_update_if_false_positive |
There was a problem hiding this comment.
imo passthrough and union with previous successes
SyntaxColoring
changed the title
SyntaxColoring
commented
Nov 20, 2024
Comment on lines
+302
to
+314
| def append(self, other: Self) -> Self: | ||
| """Apply another `StateUpdate` "on top of" this one. | ||
|
|
||
| This object is mutated in-place, taking values from `other`. | ||
| If an attribute in `other` is `NO_CHANGE`, the value in this object is kept. | ||
| """ | ||
| fields = dataclasses.fields(other) | ||
| for field in fields: | ||
| other_value = other.__dict__[field.name] | ||
| if other_value != NO_CHANGE: | ||
| self.__dict__[field.name] = other_value | ||
| return self | ||
|
|
There was a problem hiding this comment.
Is append() a good name for this? Is there a naming scheme that harmonizes better with reduce()?
Comment on lines
315
to
317
| @classmethod | ||
| def reduce(cls: typing.Type[Self], *args: Self) -> Self: | ||
| """Fuse multiple state updates into a single one. |
There was a problem hiding this comment.
Note to self: Can probably implement reduce() in terms of append().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes RQA-3567.
Test Plan and Hands on Testing
commandType: "home"intent: "fixit"command.Changelog
There are 4 substeps in an
aspiratecommand:blowOutand prepare for theaspirate.Prior work already lets us recover from overpressure and stall errors in steps 3 and 4. This does the same for steps 1 and 2.
Review requests
Risk assessment