feat(protocol-designer): onboarding animations #16927
Open
+79
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
requested review from
koji,
shlokamin and
ncdiehl11
and removed request for
a team
koji
reviewed
Nov 21, 2024
|
it is partially missing. is this an expected behavior? |
@koji ya so the animations get cropped in order to fit the space. If you adjust the viewport, it will not crop that part out. |
|
From the description, you did optimize webm files already. |
koji
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AUTH-974
Overview
Add onboarding animations to the onboarding flow
Test Plan and Hands on Testing
Test it out in the sandbox - i feel like there are some optimization issues with step 4 and 5 since they're the biggest files. lmk if you think its worth trying to optimize more?? I'm sort of out of ideas on what to try though without risking lowering the resolution.
Changelog
Risk assessment
low