Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(abr-testing): Update simulate #16929

Merged
merged 7 commits into from
Nov 21, 2024
Merged

fix(abr-testing): Update simulate #16929

merged 7 commits into from
Nov 21, 2024

Conversation

AnthonyNASC20
Copy link
Contributor

Overview

Fixes the issue of make-simulate not simulating liquid setups in protocols folder

@AnthonyNASC20 AnthonyNASC20 requested a review from a team as a code owner November 21, 2024 15:44
sfoster1
sfoster1 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@sfoster1 sfoster1 changed the title Update simulate fix(abr-testing): Update simulate Nov 21, 2024
rclarke0
rclarke0 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@rclarke0 rclarke0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and approved.

@rclarke0 rclarke0 merged commit f37ef0a into edge Nov 21, 2024
40 checks passed
@rclarke0 rclarke0 deleted the update_simulate branch November 21, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rclarke0 rclarke0 rclarke0 approved these changes

@sfoster1 sfoster1 sfoster1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnthonyNASC20 @sfoster1 @rclarke0