Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(protocol-designer): fix copy of incompatible file type modal and update settings page to match design #16937

Draft
wants to merge 5 commits into
base: edge
Choose a base branch
from
Draft

fix(protocol-designer): fix copy of incompatible file type modal and update settings page to match design #16937

wants to merge 5 commits into from
+31 −31

Conversation

syao1226
Copy link
Collaborator

@syao1226 syao1226 commented Nov 21, 2024 •
edited
Loading

fix RQA-3656, RQA-3650

Overview

  1. updated copy of incompatible file type modal to match with design
  2. updated Settings to match with design

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

jerader
jerader approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@syao1226 syao1226 changed the title fix(protocol-designer): fix copy of incompatible file type modal fix(protocol-designer): fix copy of incompatible file type modal and update settings page to match design Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerader jerader jerader approved these changes

Assignees
No one assigned
Labels
authorship
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syao1226 @jerader