Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components, protocol-designer): add hover state for Checkbox component and StyledLabel #16942

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Nov 21, 2024

Overview

Fix enabled and hover state background color for both checked and unchecked states of Checkbox component, and add hover state for StyledLabel one-off in SelectPipettes component.

Closes RQA-3655

Test Plan and Hands on Testing

  • create new OT-2 protocol and land on select pipettes step
  • select type and volume
  • click around and hover on tiprack options and verify that hover state is correct
  • hover "Add custom pipette tips" and "Show default tips" links and verify text changes to blue50
Screen.Recording.2024-11-21.at.3.27.00.PM.mov

Changelog

  • add hover states

Review requests

  • see test plan

Risk assessment

low

…onent and StyledLabel

Fix enabled and hover state background color for both checked and unchecked states of Checkbox
component, and add hover state for StyledLabel one-off in SelectPipettes component.

Closes RQA-3655
@ncdiehl11 ncdiehl11 self-assigned this Nov 21, 2024
@ncdiehl11 ncdiehl11 marked this pull request as ready for review November 21, 2024 20:27
@ncdiehl11 ncdiehl11 requested review from a team as code owners November 21, 2024 20:27
@ncdiehl11 ncdiehl11 removed request for a team November 21, 2024 20:28
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you for fixing this.

just left one comment on show default tips text button

@ncdiehl11 ncdiehl11 merged commit cb182a0 into edge Nov 21, 2024
58 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_pd-create-file-hover branch November 21, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants