Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): library build refactoring #109

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Apr 27, 2022

Fixes #18
FIxes #100

  • Package this fix in iotmapmanager-labs
  • Test iotmapmanager-labs in the root project
  • Test iotmapmanager-labs in a real Orange Angular project
  • Check if other packages should be defined as peerDependencies (@types/leaflet, @types/leaflet.markercluster, leaflet-polylineoffset and leaflet.markercluster)
  • Study exactly where the Bounds are not valid issue comes from
  • Finish the work to migrate to Node 16 while we are testing it in a real project
  • Fix the test project to embed resources in angular.json and not in index.html
  • Before merging it, remove modification in component.ts

What's been done regarding Node 16

We observed some issues while building the library with Node 14 so I embedded this modification as well in this PR:

How to test it locally / manually

  1. Run npm i at the root of the project
  2. Go to src/iotMapmanager and then run npm i
  3. Run npm pack
  4. Go to /tmp and run rm -rf iotmap* package ; cp /Users/ju/IOT-Map-Component/src/iotMapManager/iotmapmanager-2.6.8.tgz . ; tar -xvf iotmapmanager-2.6.8.tgz ; rm -rf /Users/ju/IOT-Map-Component/node_modules/iotmapmanager/* ; cp -R package/* /Users/ju/IOT-Map-Component/node_modules/iotmapmanager/
  5. Go back to the root of this branch and run npm run start

How to test it with the iotmapmanager-labs

TODO

@julien-deramond
Copy link
Member Author

julien-deramond commented Apr 27, 2022

Some notes for triage

  • in src/iotMapManager/package-lock.json leaflet version is 1.7.1
  • Need to regenerate package-lock.json from scratch to handle correctly the leaflet versions?

@julien-deramond
Copy link
Member Author

This PR would need to be updated to reflect the new architecture. But the principle is probably still valid and relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bounds are not valid Node 16
1 participant