Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OUDS] feat: Add "Elevation" tokens, utilities and documentation - new version #2741

Merged
merged 22 commits into from
Sep 24, 2024

Conversation

hannahiss
Copy link
Member

@hannahiss hannahiss commented Sep 19, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Closes #2596

Description

To add in the main issue:

  • Modify site/content/docs/0.0/utilities/shadows.md when we'll have components and/or $enable-shadows
  • Modify site/content/docs/0.0/layout/z-index.md when some components are present (navigation, tooltips, popovers, etc.)

Motivation & Context

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with a responsive display

Development

  • My change follows the developer guide
  • I have added JavaScript unit tests to cover my changes
  • I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • My new component is well displayed in Storybook
  • My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 7346e58
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/66f2a84195cf820008250275
😎 Deploy Preview https://deploy-preview-2741--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

site/content/docs/0.0/migration.md Outdated Show resolved Hide resolved
@julien-deramond julien-deramond marked this pull request as ready for review September 24, 2024 09:11
@julien-deramond julien-deramond marked this pull request as draft September 24, 2024 09:26
@julien-deramond julien-deramond marked this pull request as ready for review September 24, 2024 09:29
vprothais and others added 3 commits September 24, 2024 11:55
The comment has been split in 2 lines because Hugo doesn't generate a p tag if the line starts with an html comment
$ouds-elevation-spread-focus: $ouds-elevation-spread-300 !default;

$ouds-elevation-color-none: rgba(0, 0, 0, 0) !default;
$ouds-elevation-color-raised: rgba(0, 0, 0, .32) !default;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to be careful here when we'll tackle the colors, as it doesn't work for the dark mode actually.

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Good job!

@julien-deramond julien-deramond linked an issue Sep 24, 2024 that may be closed by this pull request
1 task
@julien-deramond julien-deramond merged commit bd4bead into ouds/main Sep 24, 2024
14 checks passed
@julien-deramond julien-deramond deleted the ouds/main-his-tokens-elevation branch September 24, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

[OUDS] Tokens: Elevation
3 participants