Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OUDS] Add "Grid" tokens, utilities, examples and documentation #2744

Draft
wants to merge 13 commits into
base: ouds/main
Choose a base branch
from

Conversation

hannahiss
Copy link
Member

@hannahiss hannahiss commented Sep 26, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Closes #2609

Description

  • uncomment and restore documentation pages in Layout: Breakpoints, Containers, Grid, Columns, Gutters, Utilities
  • Add new example page "grid-system" to test grids

Motivation & Context

Types of change

  • Breaking change (fix or feature that would change existing functionality)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with a responsive display

Development

  • My change follows the developer guide
  • I have added JavaScript unit tests to cover my changes
  • I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • My new component is well displayed in Storybook
  • My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@hannahiss hannahiss changed the base branch from main to ouds/main September 26, 2024 13:02
Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 1f66b64
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/66fe8d286415a20008e57ee6
😎 Deploy Preview https://deploy-preview-2744--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond changed the title Add "Grid" tokens, utilities, examples and documentation [OUDS] Add "Grid" tokens, utilities, examples and documentation Sep 26, 2024
@julien-deramond julien-deramond added this to the OUDS milestone Sep 26, 2024
@julien-deramond julien-deramond linked an issue Sep 26, 2024 that may be closed by this pull request
1 task
//$ouds-grid-max-width-700: 1879 !default;
//$ouds-grid-max-width-800: 1920 !default;

$ouds-grid-margin-100: 16 !default;
Copy link
Member

@julien-deramond julien-deramond Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we shouldn't use a multiplicator based on $dimension-base. They've done it like this in OUDS Android for instance: https://github.com/Orange-OpenSource/ouds-android/blob/db96b330d4df815d802e773f8bfc707894c3c8d0/global-raw-tokens/src/main/java/com/orange/ouds/tokens/global/raw/GridRawTokens.kt#L24

Even if the dimension tokens are not there yet, we could still introduce the $dimension-base: 4 !default in this PR.

@julien-deramond

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress / Draft
Development

Successfully merging this pull request may close these issues.

[OUDS] Tokens: Grid
3 participants