-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OUDS] Add "Grid" tokens, utilities, examples and documentation #2744
base: ouds/main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
scss/tokens/_raw.scss
Outdated
//$ouds-grid-max-width-700: 1879 !default; | ||
//$ouds-grid-max-width-800: 1920 !default; | ||
|
||
$ouds-grid-margin-100: 16 !default; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we shouldn't use a multiplicator based on $dimension-base
. They've done it like this in OUDS Android for instance: https://github.com/Orange-OpenSource/ouds-android/blob/db96b330d4df815d802e773f8bfc707894c3c8d0/global-raw-tokens/src/main/java/com/orange/ouds/tokens/global/raw/GridRawTokens.kt#L24
Even if the dimension tokens are not there yet, we could still introduce the $dimension-base: 4 !default
in this PR.
This comment was marked as resolved.
This comment was marked as resolved.
…ouds/main-his-tokens-grid
Note: Please transform
- [ ]
into- (NA)
in the description when things are not applicableRelated issues
Closes #2609
Description
Motivation & Context
Types of change
Live previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge