댓글 페이지 - 개선사항 구현 및 버그 수정 #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
댓글 수정 시 reconfigureItems를 사용하기 위해 Item을 고유 ID인 commentID로 받도록 수정했습니다.
…ing it 답글버튼을 누르거나 댓글 수정버튼을 누른 상태에서 어떠한 댓글을 삭제하고 나면, targetID가 nil로 처리되어 UI상 답글 또는 댓글 수정중이라고 뜨고 있음에도 댓글로 달리는 버그가 존재하였고, 이를 수정했습니다.
- 차후 공지 관련 ViewModel에서도 사용될 예정이기 때문에, 갈아 끼워 적용할 수 있도록 팩토리 패턴을 구현하였습니다.
WhiteHyun
added
🐛 bug
soobin-k
approved these changes
Apr 20, 2023
Comment on lines
+11
to
+29
| protocol BoardDetailViewModelFactory { | ||
| static func make(plubbingID: Int, boardModel: BoardModel) -> BoardDetailViewModel | ||
| } | ||
|
|
||
| final class BoardDetailViewModelWithFeedsFactory: BoardDetailViewModelFactory { | ||
|
|
||
| private init() { } | ||
|
|
||
| static func make(plubbingID: Int, boardModel: BoardModel) -> BoardDetailViewModel { | ||
| return BoardDetailViewModel( | ||
| plubbingID: plubbingID, | ||
| content: boardModel, | ||
| getCommentsUseCase: DefaultGetCommentsUseCase(), | ||
| postCommentUseCase: DefaultPostCommentUseCase(), | ||
| deleteCommentUseCase: DefaultDeleteCommentUseCase(), | ||
| editCommentUseCase: DefaultEditCommentUseCase() | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
댓글 관련된 usecase들을 한눈에 파악하기 좋은 것 같습니다👍👍
| @@ -42,7 +45,7 @@ protocol BoardDetailViewModelType: BoardDetailViewModel { | |||
|
|
|||
| protocol BoardDetailDataStore { | |||
| var content: BoardModel { get } | |||
| var comments: [CommentContent] { get } | |||
| var comments: Set<CommentContent> { get } | |||
There was a problem hiding this comment.
set 사용하니깐 코드도 간결해지고, 성능도 개선될 것 같네요..!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 PR 요약
🌱 작업한 내용
300자 이내로만 댓글이 써질 수 있도록 구현 (delegate로 처리)
댓글 수정 중 다른 댓글을 삭제한 뒤 수정 버튼을 누르면 댓글로 처리되는 버그 수정(
DeleteIDObserver을 별도로 추가해서 처리)개선사항
Set으로 변경, 집합연산을 수행하기 위함📸 스크린샷
📮 관련 이슈