Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

게시글 좋아요 기능 구현 #336

Merged
merged 6 commits into from
May 3, 2023
Merged

Conversation

WhiteHyun
Copy link
Member

@WhiteHyun WhiteHyun commented May 1, 2023

📌 PR 요약

🌱 작업한 내용

  • 게시글 좋아요 기능 구현
  • BoardDetailViewModelFactory 파라미터 일부 수정
    • 게시글 좋아요 기능을 구현하려면 게시글 상세조회 API를 호출해야하는데, 기존에 받았던 boardModel을 이제는 상세조회 API로부터 받으므로 BoardDetailViewModelFactory.make를 실행할 때 boardModel을 파라미터로 받을 필요가 없어졌습니다.

📸 스크린샷

스크린샷
Simulator Screen Recording - iPhone 14 Pro - 2023-05-01 at 23 29 35

📮 관련 이슈

BoardModel 타입의 content를 제거하고, 게시물 상세 조회 API로 대체하여 데이터를 파싱했습니다.
plubbingID와 feedID만을 가지고 usecase를 구성하기 때문에, boardModel을 받을 필요가 없어졌습니다.
@WhiteHyun WhiteHyun added 😎 Enhancement New feature or request 🍎 ConfigureUI 화면 프로토타입 UI 구현 🥳MainPage labels May 1, 2023
@WhiteHyun WhiteHyun self-assigned this May 1, 2023
@WhiteHyun WhiteHyun added the D+2 일반적인 범주의 PR이에요. 이틀 이내에 리뷰 해주시면 됩니다 label May 2, 2023
Copy link
Contributor

@soobin-k soobin-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 승현님!

@WhiteHyun WhiteHyun merged commit 5791e3c into develop May 3, 2023
@WhiteHyun WhiteHyun deleted the feat/302-Comment/Likes branch May 3, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍎 ConfigureUI 화면 프로토타입 UI 구현 D+2 일반적인 범주의 PR이에요. 이틀 이내에 리뷰 해주시면 됩니다 😎 Enhancement New feature or request 🥳MainPage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants