Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T3 Modifications #28

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

dwaring87
Copy link
Contributor

scale categories are sorted by key in the Trait Dictionary (categories are in a random order in the existing TD)
add new variables derived from drone imagery from Texas UASHub
add additional agronomic and disease traits requested by breeders

scale categories are sorted by key in the Trait Dictionary
add new variables derived from drone imagery from Texas UASHub
add additional agronomic and disease traits requested by breeders
@cpommier
Copy link
Contributor

Hi @dwaring87 ,
I just merged a rather big change that has been waiting for some time, see #17 .
One important change to take into account is the ordering by variableID column in the CSV. I hope it will not be too troubelsome to reapply your changes. Sorry for the delay in merging and the possible inconvenient it triggered.

@cpommier
Copy link
Contributor

Maybe better to reapply your changes by hand from a fresh pull of the master branch rather than trying to resolve conflicts using meld or any git diftool ?

EXISTING TRAITS NOW USED BY T3:

1038
1068
1161
1168
1183
1198
1199
1228
1263
1457
1468

REMOVED DUPLICATES OF EXISTING VARIABLES:

0501073
0501087

NEW VARIABLES ADDED:

0501157
0501158
0501159
0501160
0501161
0501162
0501163
0501164
0501165
0501166
0501167
0501168
0501169
0501170
0501171
0501172
0501173
0501174
0501175
0501176
0501177
0501178
0501179
0501180
0501181
0501182
0501183
0501184
0501185
0501186
0501187
0501188
@dwaring87
Copy link
Contributor Author

@cpommier I think this new commit has all of the changes that were in the original PR from last year. We generate the trait dictionary file programtically, but it's difficult to compare to the planteome version since the scale categories are in a random order. If those could be sorted numerically, it would make comparisons a lot easier.

@dwaring87
Copy link
Contributor Author

@cpommier Any update on this PR? I'd like to not have it sit for too long again and become out of date with the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants