Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow sharded database backups as well #74

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

Daesgar
Copy link
Contributor

@Daesgar Daesgar commented Jul 12, 2024

If we perform a whole database backup it should be done per shard, because otherwise sharded tables won't be fully backed up to S3.

This just passes the is_sharded parameter from the scheduled backup to the backup execution.

@Daesgar Daesgar requested a review from fuziontech July 12, 2024 13:30
@Daesgar Daesgar merged commit 4a77050 into main Jul 12, 2024
2 checks passed
@Daesgar Daesgar deleted the database-backups-sharded branch July 12, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant