Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not trigger hardcoded password on empty string, #714 #738

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

do not trigger hardcoded password on empty string, #714 #738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions bandit/plugins/general_hardcoded_password.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,9 @@ def hardcoded_password_funcarg(context):
"""
# looks for "function(candidate='some_string')"
for kw in context.node.keywords:
if isinstance(kw.value, ast.Str) and RE_CANDIDATES.search(kw.arg):
if isinstance(kw.value, ast.Str) \
and kw.value.value != '' \
and RE_CANDIDATES.search(kw.arg):
return _report(kw.value.s)


Expand Down Expand Up @@ -214,5 +216,7 @@ def hardcoded_password_default(context):
# go through all (param, value)s and look for candidates
for key, val in zip(context.node.args.args, defs):
if isinstance(key, (ast.Name, ast.arg)):
if isinstance(val, ast.Str) and RE_CANDIDATES.search(key.arg):
if isinstance(val, ast.Str) \
and val.value != '' \
and RE_CANDIDATES.search(key.arg):
return _report(val.s)