Allow user to set precision
in CWT, increase default to 12
#570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses this Issue. Detailed explanation here; a summary:
precision
distorts CWT, and heavily at high scales.64
are increasingly distorted.precision=10
is low, andprecision=12
does not add much computation cost, while considerably remedying 1-3.At the least, the user should get to decide
precision
instead of carving it in stone. And a doc/comment should be made about these caveats.Improvement comparison
Code