-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor from More Features to Embeds, Events, Markdown #236
base: main
Are you sure you want to change the base?
Conversation
I added a couple markdown examples, and moved the element style pages into their own category. |
message = "Hello world!" | ||
print(message) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this doesn't format correctly at the moment. Fix before merging. May be resolved by #239.
✅ Deploy Preview for pycord ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Add the "text" flag to code blocks that aren't supposed to show with syntax highlight as they are about an example without it. Split the Code Block and Quote Block sections into paragraphs. Add an example for single-line code block with syntax highlight. Improve some sentences here and there.
Fixed. No more warnings but the examples are showing wrong. |
The syntax isn't exactly the one explained immediately above but the final result looks exactly the same and we hopefully no longer get any warning there.
…into more-features
<DiscordComponent> | ||
<DiscordMessage profile="robocord"> | ||
<DiscordMarkdown> | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to show this example properly, this code block should be rendered with syntax highlight. Since it was showing python
as text, I reverted the change for now. The next 2 examples have the same problem.
<DiscordComponent> | ||
<DiscordMessage profile="robocord"> | ||
<DiscordMarkdown> | ||
> This is a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we write >>>
, we get an error. If we write >
for each line, the first line shows as quote block correctly but the second >
shows as text instead of being rendered as quote block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should always write the correct syntax, and change the discordcomponent if it fails to parse correctly
Split the More Features page into 3 separate pages: Embeds, Events, Markdown. Furthermore, add Related Topics to connect the Embeds page and the Markdown page to each other.