Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add USR1 signal handlers to show widget menus #216

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

apebl
Copy link

@apebl apebl commented Aug 16, 2024

This allows the menu to be displayed by sending a SIGUSR1 signal to a widget process.

Why

GNOME Shell does not support legacy tray icons, so I created a wrapper extension for use on GNOME. This extension simply sends a USR1 signal to widgets to open the menu.

https://github.com/apebl/gnome-ext-qubes-tray-widgets

Why not using tray icon extensions

The tray icon extensions I tested lead to shell crashes when a VM tries to create tray icons:

It seems that this issue is not specific to an extension but rather an incompatibility between GNOME and Qubes OS.

Instead of bothering with the problem, I decided to implement a simple alternative method as I described.

@apebl apebl force-pushed the main branch 2 times, most recently from 23b09f5 to 77147b2 Compare August 17, 2024 03:29
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.71%. Comparing base (5902fa1) to head (c4002a0).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
- Coverage   93.72%   93.71%   -0.01%     
==========================================
  Files          57       57              
  Lines       10843    10843              
==========================================
- Hits        10163    10162       -1     
- Misses        680      681       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marmarta
Copy link
Member

marmarta commented Sep 3, 2024

This is a problem with Gnome, yeah; they decided nobody actually needs tray icons, basically, and so they will not support them fully, except for Gnome's own.

Anyway, on-topic: I generally like this, just one ask: could you document it also? In the code comments, but ideally also in qubes docs themselves? So that it's easier to find for someone who is not you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants