Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow access to numbering.xml, header1.xml, and footer1.xml docs #1

Merged
merged 1 commit into from
Mar 1, 2018

Conversation

yjukaku
Copy link

@yjukaku yjukaku commented Mar 1, 2018

We need access to numbering.xml for figuring out the type of list defined in a document.

See ruby-docx#42

@yjukaku yjukaku requested review from oboxodo and salidux March 1, 2018 16:28
@yjukaku yjukaku merged commit 9b49820 into master Mar 1, 2018
Copy link
Member

@oboxodo oboxodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Will you send a PR upstream?

@yjukaku
Copy link
Author

yjukaku commented Mar 1, 2018

No, the upstream hasn't been updated in 4 years 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants