Forbid inefficient TensorDescriptor initialization #3393
+78
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAHEK7
requested review from
BrianHarrisonAMD,
junliume and
BradPepersAMD
as code owners
averinevg
reviewed
Nov 18, 2024
averinevg
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializing TensorDescriptor from
std::vector<int>is very inefficient due to extra checks and multiple intermediate vector, since internallystd::vector<size_t>is used.Changed all the initializations to the native
size_t, removed constructors withstd::vector<int>and added workarounds for a legacy descriptors initializations withint's.It increased performance for the current RNN implementation for a few percents.