Use TARGET_RUNTIME_DLLS generator expression #739
Draft
+21
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TARGET_RUNTIME_DLLS generator expression added in CMake 3.21 provides exactly the functionality that is desired on Windows for copying the DLLs, and it is more robust than the existing glob.
cgmb
added
noOptimizations
cgmb
requested review from
jzuniga-amd,
tfalders,
qjojo,
EdDAzevedo and
jmachado-amd
as code owners
(Not copy the test directory to the DLLs.)
The rocblas DLL is in bin, but the Tensile library is in bin/rocblas/library
|
Well, it seems to be working now, except it doesn't copy these LAPACK libraries: Omitting libcblas is fine, but the others seem to be runtime dependencies of libblas.dll or liblapack.dll and are required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TARGET_RUNTIME_DLLS generator expression added in CMake 3.21 provides exactly the functionality that is desired on Windows for copying the DLLs, and it is more robust than the existing glob.