scripts for performance tracking system #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzuniga-amd
added
the
noOptimizations
jzuniga-amd
requested review from
tfalders,
cgmb,
qjojo,
EdDAzevedo,
jmachado-amd and
a team
as code owners
|
I noticed that we have a docs section on benchmarking. Do you think this information needs to be added to docs too? Or is it something that only developers/contributors would be concerned with? |
AGonzales-amd
approved these changes
Sep 26, 2024
Correct, this is intended only for internal use (by developers and CI) |
* detect invalid combination * add hermitian versions
tfalders
approved these changes
Oct 25, 2024
| POTRFBATCH tests are run with the given precision and sizes | ||
| """ | ||
| def potrfBatch_suite(*, suite, precision, sizenormal, sizebatch): | ||
| fn = 'potrf_batched' |
There was a problem hiding this comment.
Other tests test the strided_batched function. Is there a reason POTRF is testing the batched function?
There was a problem hiding this comment.
Yeah, all batch functions in cusolver are strided_batched, but for some reason, potrf is _batched
jmachado-amd
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new scripts to generate internal performance reports to track the optimization efforts (see the README file for more details).