Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torch update #93

Draft
wants to merge 20 commits into
base: develop
Choose a base branch
from
Draft

Torch update #93

wants to merge 20 commits into from

Conversation

loggrado
Copy link
Contributor

Overhaul torch instructions.

  • Split into two pages: Install, and Docker
  • Install page exclusively discusses methods for installing pytorch
  • Docker:
    • Provide example dockerfiles (BEST PRACTICE) instead of encouraging "live builds" and commiting
    • [TEMPORARY] Remove sections on building from source, and upstream docker image
      • I was unable to reproduce either of these "installation" methods.
      • Have reached out to Peng Sun (who builds the base images) for help in revamping these sections

@loggrado loggrado requested a review from a team as a code owner March 13, 2024 21:54
@LisaDelaney LisaDelaney marked this pull request as draft March 14, 2024 15:30
@randyh62 randyh62 marked this pull request as ready for review April 12, 2024 19:02
@lpaoletti
Copy link
Contributor

Please rebuild it.
I'll review when it builds

@lpaoletti
Copy link
Contributor

@loggrado
I'll review it when the docs build. Is that ok?

@peterjunpark peterjunpark marked this pull request as draft April 26, 2024 17:59
…ch_update"

This reverts commit e84c48f, reversing
changes made to 55c77b9.
Fixes build error due to duplicate resources in TOC.
Fixes wording
@peterjunpark
Copy link
Contributor

peterjunpark commented Apr 26, 2024

Hi @loggrado. I understand you want to replace docs/how-to/3rd-party/pytorch-install.rst with docs/how-to/3rd-party/pytorch/install.rst and pytorch/docker.rst.

Docs URLs are generated based on file structure. Deleting pytorch-install.rst is problematic because other ROCm documentation and very many ML blog posts on the portal refer to this URL.

I fixed the merge conflicts as the PR is very stale, but I didn't accept the removal of this file. If the decision is made to actually remove pytorch-install.rst, you'll have to do it again.

@lpaoletti Please review the new content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants