Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .github build scripts- cleanup, use Ubuntu-20.04, use Node-20 #1246

Merged

Conversation

hans-schmidt
Copy link
Contributor

The Ravencoin repository tests each new Pull Request submission by attempting to build binaries with the new PR. But for the past year, it has interpreted all PRs as bad because the code for the build system is broken. Specifically, it uses Ubuntu-18.04 which is no longer supported by Github (fails) and it uses Node-16 which is deprecated (generates errors).

This PR updates Ravencoin's build system to use Ubuntu-20.04 and Node-20. It also removes code related to AWS cache storage which Overstock used years ago, and it does some other code clean-up.

This PR is for the master branch. Another PR has been submitted for the develop branch.
No changes are made to the actual Ravencoin source code outside of the build system.

Similar build system changes have already been implemented and tested on the Evrmore blockchain codebase.

Copy link
Contributor

@HyperPeek HyperPeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to update on develop, straight forward change, approved.

Copy link
Collaborator

@TronBlack TronBlack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Reviewed. Not sure removal of dependency build is necessary (vs setting FORCEBUILDDEPS="0", but it can be fixed/replaced later if desired.

@TronBlack TronBlack merged commit 6d48ae0 into RavenProject:master May 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants