Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README for new makefile #195 #197

Closed
wants to merge 1 commit into from

Conversation

surajpaib
Copy link

No description provided.

Copy link
Member

@nirs nirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work @surajpaib, but I'm afraid the original issue should be closed wontfix, and we need to remove the makefile instead :-)


./rose-server

Open a browser at http://\<server-address\>:8880 to view and control the game.

Start up to 2 clients:

make client
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this does not work - the client needs a driver module argument.

I think we need to remove the makefile instead of updating the readme. It helps only with the initial setup, and using a makefile breaks compatibility on windows.


./rose-server

Open a browser at http://\<server-address\>:8880 to view and control the game.

Start up to 2 clients:

make client

Or alternatively,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having alternatives for everything is confusing. We should have one simple way that works for everyone.

@@ -57,6 +70,9 @@ Command line interface
----------------------

You can control the game from the command line using the rose-admin tool.

make admin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue, a server address is needed, and then a command (e.g. start) with optional arguments (e.g set-rate 5)

@nirs
Copy link
Member

nirs commented Oct 24, 2017

@surajpaib closing this as we plan to remove the makefile, see #203. Thanks for your work!

@nirs nirs closed this Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants