Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): permissive prometheus_exporter dependency #218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vkrizan
Copy link

@vkrizan vkrizan commented Feb 3, 2021

allowing to have versions 0.4 up to but not inluding 1.0 starting
with version 0.4.5.

@vkrizan
Copy link
Author

vkrizan commented Feb 3, 2021

@slemrmartin, @lindgrenj6, @syncrou, would you guys be able to have a look. (I was unable to set reviewers.) Thanks.

allowing to have versions 0.4 up to but not inluding 1.0 starting
with version 0.4.5.
@vkrizan vkrizan force-pushed the higher-ver-of-prometheus-exporter branch from ae29372 to fd34b26 Compare February 3, 2021 12:12
@vkrizan
Copy link
Author

vkrizan commented Feb 3, 2021

Hmm, there would be more changes to deps required to alleviate the version restrictions.

@dippy-bot
Copy link

Checked commit vkrizan@fd34b26 with ruby 2.5.7, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 👍

@slemrmartin
Copy link
Contributor

@vkrizan have you tried the gem with prometheus in app-interface, is higher version compatible?
Basically how it should influence version of this gem (patch/minor)?

@vkrizan
Copy link
Author

vkrizan commented Feb 9, 2021

@slemrmartin, we use prometheus_exporter 0.5.1 in Compliance in production. I can lock it up to 0.6.

@lindgrenj6
Copy link
Contributor

Hey @vkrizan, thanks for the PR. Looking at this it basically locks us at 0.4.z, not up to 0.y.z.

If we want to lock it to basically anything pre-1.0 but greater than 0.4.5 we could lock like this: ~ 0.4, >= 0.4.5

@vkrizan
Copy link
Author

vkrizan commented Apr 12, 2021

@lindgrenj6 the suggestion looks good.

There were more of these that need to be updated in similar manor to allow us to consume the lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants