Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: proxies can now be set using HTTPS_PROXY #261

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

quintesse
Copy link
Contributor

@quintesse quintesse commented Sep 13, 2024

For now this simply extracts the host and port from the proxy URL and uses those to connect, just if we were using the RHT_INSIGHTS_JAVA_PROXY_HOST and PORT variables.

This very likely too simple. First I'm not really sure if using RHT_INSIGHTS_JAVA_PROXY_HOST/PORT actually connects using SSL or not and secondly a proxy URL could contain authentication information which we don't use right now.

Fixes MWTELE-42

@quintesse
Copy link
Contributor Author

@aslicerh in the end I decidede against showing a messages when HTTP_PROXY is set because the class that handles the proxy setup does no logging whatsoever so I wasn't sure it was a good idea to add some. THe other reason is that for the server side it's probably okay to give this warning, most likely you're not running anything else on the server. But for a client library we cannot assume that environment variables are only used for the app we're running in. So giving warnings (or even errors like the server) is probably too restrictive.

@aslicerh
Copy link
Collaborator

@aslicerh in the end I decidede against showing a messages when HTTP_PROXY is set because the class that handles the proxy setup does no logging whatsoever so I wasn't sure it was a good idea to add some. THe other reason is that for the server side it's probably okay to give this warning, most likely you're not running anything else on the server. But for a client library we cannot assume that environment variables are only used for the app we're running in. So giving warnings (or even errors like the server) is probably too restrictive.

I think that is a fair assessment.

Copy link
Collaborator

@aslicerh aslicerh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Even if this is a first step, we can do more as needed.

Copy link
Collaborator

@kittylyst kittylyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments.

Copy link
Collaborator

@kittylyst kittylyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kittylyst kittylyst merged commit 0266b14 into RedHatInsights:main Sep 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants