forked from sveltejs/kit
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Environment API experiments #1
Open
Rich-Harris
wants to merge
63
commits into
main
Choose a base branch
from
environment-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext virtual module
…t node environment as fallback
… to error handling and assets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is just a place to experiment with the work started in sveltejs#12637
thoughts, in no particular order:
maybe adapters should be able to influence the Vite config (in addition to creating environments, they could set aliases etc)? Then again there probably aren't many things they should be responsible for, so the conservative thing to do would be to just rely on them to create environmentsyeah I'm pretty sure this is a nopostbuild
andpreview
. this feels a bit 'draw the rest of the owl' right nowServer
and instantiating it with other stuff you imported, you should just importserver
and it should come with properties likebase
and methods likeserver.isAsset(request)
andserver.isPrerendered(request)
already configuredgetClientRequest
in devread
— in prod the adapter needs to provide an implementation, but in dev surely it only needs to say whether or not it's supported (and this should mean we no longer need all the finickyAsyncLocalStorage
/before_handle
stuff to determine whether or not it's being used in a route that doesn't support it)request.platform
and theemulate
function on adapters, neither is needed in this new worldthoughts on the Environment API itself
dispatchFetch
stuff feels ropeyModuleRunner
seems very elaborate. would love to see a much simpler API here