Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from dorny/test-reporter to test-summary/action #211

Merged
merged 8 commits into from
Dec 15, 2023

Conversation

wicksipedia
Copy link
Member

@wicksipedia wicksipedia commented Nov 29, 2023

  • test results will be included in the job summary
  • simplifies actions
  • requires use of junit output Support TRX  test-summary/action#1
  • added publish and upload artifact steps
  • tested failure case by committing with failing test to ensure it works when tests fail (then reverted failing test)

Test report is now included as a summary instead of a separate job (eliminates potential issue of report being attached to wrong workflow)
CleanShot 2023-12-13 at 14 33 16

GitHub templates/workflows now included in template
CleanShot 2023-12-13 at 14 27 34

@wicksipedia wicksipedia marked this pull request as ready for review December 7, 2023 00:01
@wicksipedia wicksipedia linked an issue Dec 7, 2023 that may be closed by this pull request
Copy link
Member

@danielmackay danielmackay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 comments.

tests/Directory.Packages.props Show resolved Hide resolved
.github/workflows/build-and-test.yml Show resolved Hide resolved
Copy link
Member

@danielmackay danielmackay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The version number in CleanArchitecture.nuspec has been downgraded from 0.7.3 to 0.7.0. This can be due to dependency issues or rollback requirements.
@wicksipedia wicksipedia merged commit 08c35b4 into main Dec 15, 2023
1 check passed
@wicksipedia wicksipedia deleted the 110-buildtest-workflow branch December 15, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Add build and test github workflow
2 participants