Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump chai to 5.0.0 #1018

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Bump chai to 5.0.0 #1018

merged 2 commits into from
Jan 19, 2024

Conversation

bpedersen2
Copy link
Contributor

  • fix requires -> import

@bpedersen2
Copy link
Contributor Author

Superseeds: #983

@bpedersen2 bpedersen2 force-pushed the chai-5.0.0 branch 4 times, most recently from ca67483 to b6838cc Compare January 19, 2024 10:39
@bpedersen2
Copy link
Contributor Author

See also chaijs/chai#1578!

chai is now esm only and needs dynamic imports

Junjiequan
Junjiequan approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@Junjiequan Junjiequan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Just it seems to contain minor conflicts to be resolved

@bpedersen2
Bump chai to 5.0.0
69358d5 
 - fix requires -> dynamic import
 - should registered vi -r on command

Change-Id: Iadf9a5146282cbbc183b2d6b8e5db2da33bf2f13
@bpedersen2 bpedersen2 enabled auto-merge (rebase) January 19, 2024 13:11
@bpedersen2 bpedersen2 merged commit d4b5d9e into SciCatProject:master Jan 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Junjiequan Junjiequan Junjiequan approved these changes

@nitrosx nitrosx Awaiting requested review from nitrosx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bpedersen2 @Junjiequan