Sequester with key rotation #6644
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
touilleMan
force-pushed
the
sequester-with-key-rotation
branch
10 times, most recently
from
63b87ca
to
ab64e02
Compare
touilleMan
force-pushed
the
sequester-with-key-rotation
branch
from
97d99a9
to
495f1ed
Compare
AureliaDolo
reviewed
Oct 30, 2024
| if sequester_topic_last_timestamp >= certif.timestamp: | ||
| return RequireGreaterTimestamp(strictly_greater_than=sequester_topic_last_timestamp) | ||
|
|
||
| # 4) All checks are good, now we do the actual insertion |
There was a problem hiding this comment.
Suggested change
| # 4) All checks are good, now we do the actual insertion | |
| # 3) All checks are good, now we do the actual insertion |
| // Returned if `per_participant_keys_bundle_access` field is out of date | ||
| // with the server: | ||
| // - A user part of the realm is missing | ||
| // - A user no longer (or that have never been) part of the realm is present |
There was a problem hiding this comment.
Suggested change
| // - A user no longer (or that have never been) part of the realm is present | |
| // - A user is no longer (or that have never been) part of the realm is present |
There was a problem hiding this comment.
You missed the end of the sentence: a user [...] *is* present
touilleMan
force-pushed
the
sequester-with-key-rotation
branch
from
495f1ed
to
414bde3
Compare
…-rotation-based-sequester
…d of encrypting vlobs for them
…_bundle_access` field in `TestbedEventRotateKeyRealm`
…e/revoke in server
…memory implementation of realm/vlob handling sequester webhooks
…uester service webhooks
…support in realm_rotate_key/vlob_create/vlob_update is missing)
…cording to changes to support key-rotation-based-sequester
…ording to changes to support key-rotation-based-sequester
…rvices` administration API in server
touilleMan
force-pushed
the
sequester-with-key-rotation
branch
from
414bde3
to
bba4902
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the sequester service implementation.
Specifically, we encrypt the keys bundle for sequester services, instead of encrypting each manifest as it's uploaded. It's much better that way, by the way (simpler to implement and more robust).
Yet to be done:
It's not an urgent PR (there's no need for it in the demo, I implemented it because it was quick and allowed me to validate the corrections I was thinking while working on CSPN spec).