Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hack step for packaging server wheel for macos #8923

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Remove hack step for packaging server wheel for macos #8923

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions .github/workflows/package-server.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,30 +107,6 @@ jobs:
- name: Set file for wheel version
run: cp -v libparsec/version dist/version

- name: Hack the wheel macos version
if: startsWith(matrix.os, 'macos-')
shell: bash -eux -o pipefail {0}
run: |
# Old wheel name
OLD_WHEEL_NAME=$(basename dist/parsec_cloud-*.whl)
# Unzip the wheel
mkdir temp
cd temp
unzip ../dist/$OLD_WHEEL_NAME
# Get platform new wheel name
# FIXME: We fix the version of wheel to 0.43.0 as a temporary fix for the deprecated `bdist_wheel` module
python -m pip install -U pip wheel==0.43.0 setuptools
PLATFORM=$(python -c "from wheel.bdist_wheel import get_platform; print(get_platform('.'))")
NEW_WHEEL_NAME=$(basename ../dist/parsec_cloud-*.whl | sed "s/macosx_.*_x86_64/$PLATFORM/")
# Update archive and zip back
sed -i "" "s/macosx_.*_x86_64/$PLATFORM/" parsec_cloud-*.dist-info/WHEEL
zip -r $NEW_WHEEL_NAME *
cd ..
# Replace old wheel with the new one
mv temp/$NEW_WHEEL_NAME dist/
rm dist/$OLD_WHEEL_NAME
rm -rf temp

- name: Generate requirements & constraints infos
run: python server/packaging/wheel/wheel_it.py ./server --output dist --skip-wheel

Expand Down
Loading