Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scoop-virustotal): Adjust json_path parameters to retrieve correct analysis stats #6044

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

Lutra-Fs
Copy link
Contributor

@Lutra-Fs Lutra-Fs commented Jul 6, 2024

Description

This PR aims to fix the error introduced in #5920. It uses the $single arguments in json_path to correctly extract the data instead, as previously they are enclosed with square brackets.

Motivation and Context

How Has This Been Tested?

Tested using Powershell 7

scoop virustotal eza
main/eza: 0/64, see https://www.virustotal.com/gui/file/0c5e596c990e15cbc04dce52ed9629cc8adc9c967d5e79534d6ddea020323cc4
scoop virustotal -a
main/1password-cli: 0/67, see https://www.virustotal.com/gui/file/761f2aa0f8907b397940cb69d9514efbcc4c67de6d64426e99a542edc60d615c
main/7zip: 0/64, see https://www.virustotal.com/gui/file/eb94db7341e59f1871a4d4f60165563f1881e33aef093b7d8427651c2a0f4b6f

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@niheaven
Copy link
Member

niheaven commented Jul 8, 2024

Please add the changlog entry

@Lutra-Fs Lutra-Fs changed the title fix(scoop-virustotal): Adjust json paths to retrieve correct analysis stats in VirusTotal script fix(scoop-virustotal): adjust json_path parameters to retrieve correct analysis stats Jul 8, 2024
@niheaven niheaven changed the title fix(scoop-virustotal): adjust json_path parameters to retrieve correct analysis stats fix(scoop-virustotal): Adjust json_path parameters to retrieve correct analysis stats Jul 9, 2024
@niheaven niheaven merged commit 1c271f5 into ScoopInstaller:develop Jul 9, 2024
2 checks passed
@niheaven
Copy link
Member

niheaven commented Jul 9, 2024

Please sign all your commits next time, thanks.

@Lutra-Fs Lutra-Fs deleted the fix-virustotal-path branch July 9, 2024 13:26
@Lutra-Fs
Copy link
Contributor Author

Please sign all your commits next time, thanks.

I use another PC to do the rebase work, which I did not configure GPG sign. Will check it next time.

@Lutra-Fs
Copy link
Contributor Author

Any chance to publish a hotfix version? I can see some people are complaining about the bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants