Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace pyinvoke with taskfile #275

Merged
merged 18 commits into from
Aug 22, 2023
Merged

refactor: replace pyinvoke with taskfile #275

merged 18 commits into from
Aug 22, 2023

Conversation

JonZeolla
Copy link
Member

@JonZeolla JonZeolla commented Aug 10, 2023 •
edited
Loading

Contributor Comments

This modernizes the repo by moving to Taskfile.yml from pyinvoke and also updates the related pipelines and documentation.

Pull Request Checklist

Thank you for submitting a contribution to easy_infra!

In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

  • Rebase your branch against the latest commit of the target branch
  • If you are adding a dependency, please explain how it was chosen
  • If manual testing is needed in order to validate the changes, provide a testing plan and the expected results
  • If there is an issue associated with your Pull Request, link the issue to the PR.

@JonZeolla JonZeolla changed the title feat: add published multiplatform images refactor: replace pyinvoke with taskfile Aug 10, 2023
@JonZeolla JonZeolla marked this pull request as draft August 10, 2023 23:11
@JonZeolla JonZeolla marked this pull request as ready for review August 19, 2023 19:58
@JonZeolla JonZeolla enabled auto-merge (squash) August 19, 2023 20:07
@JonZeolla JonZeolla added blocked Unable to make progress and removed blocked Unable to make progress labels Aug 19, 2023
ChiefHolland
ChiefHolland approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@ChiefHolland ChiefHolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonZeolla JonZeolla merged commit 1da9c7c into main Aug 22, 2023
19 checks passed
@JonZeolla JonZeolla deleted the add-multiplatform-support branch August 22, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChiefHolland ChiefHolland ChiefHolland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonZeolla @ChiefHolland