Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added code samples for Chrome extensions #1411

Merged
merged 14 commits into from
Jun 27, 2023
Merged

Added code samples for Chrome extensions #1411

merged 14 commits into from
Jun 27, 2023

Conversation

by-gayathri
Copy link
Contributor

Description

Added code samples for Chrome extensions

Motivation and Context

This helps users to automatically load in the browser once the test execution starts

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@netlify
Copy link

netlify bot commented Jun 26, 2023 •
edited
Loading

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit ff33185

@titusfortner
Copy link
Member

This is great. It takes a lot of work to do all of this.

To @harsha509's points.
Take a look at what we did for Firefox - https://www.selenium.dev/documentation/webdriver/browsers/firefox/#add-ons

The exact same extension for Chrome lives here - https://github.com/SeleniumHQ/selenium/tree/trunk/common/extensions

If you can copy/paste the crx extension to the same directories as the Firefox extensions, then we can use Selenium html pages, and the CI shouldn't complain.

Let me know if I can help.

@titusfortner
Copy link
Member

I actually didn't expect my monster PR to get merged so quickly (I've been working on it for weeks). But I just made rebasing your code extremely challenging. :(
Let me know if you want help.

harsha509
harsha509 approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @by-gayathri !

@harsha509
Copy link
Member

harsha509 commented Jun 27, 2023 •
edited
Loading

Congratulations on your first contribution to Selenium Docs @by-gayathri 🎉 🎉 🎉

@harsha509 harsha509 merged commit e0e2842 into SeleniumHQ:trunk Jun 27, 2023
14 checks passed
selenium-ci added a commit that referenced this pull request Jun 27, 2023
@selenium-ci
Added code samples for Chrome extensions (#1411)[deploy site]
ccc865b 
* Add sample code for extensions

* Add samples for extensions in other languages

* Review comments

* add sample crx file and update tests

* update sample code and assertions with crx file

* updated md wrt to new code changes

* resolve merge conflicts

* fix line numbers (merge-conflicts)

* typo fix

* fix typo e0e2842
titusfortner added a commit that referenced this pull request Jun 28, 2023
@titusfortner
fix bad merge with #1411
79bd106 
[deploy site]
selenium-ci added a commit that referenced this pull request Jun 28, 2023
@selenium-ci
fix bad merge with #1411
965216f 
[deploy site] 79bd106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsha509 harsha509 harsha509 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@by-gayathri @titusfortner @harsha509