window.open - mount the Popup to the relevant document.body #4219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you open a new window with
window.open
and try to open aPopup
there, thePopup
gets shown at the correct position but in the wrong window. The culprit is this line in the PortalInner.js wheredocument.body
of the initial window gets assigned to themountNode
property which is then passed toReactDOM.createPortal
.I have made the change in
Popup.js
so that the correctmountNode
gets extracted from thePopup
'sreferenceElement
(eithercontext
ortrigger
) through the DOM's.ownerDocument
property.The fix also needs to be made for
Modal
(usetrigger
's.ownerDocument
ifmountNode
is not provided),Dimmer
andTransitionablePortal
components that all usePortal
component.For an example of using
window.open
with React see Using a React 16 Portal to do something cool and Popout Windows in React.