Toolchain: Update LLVM to 19.1.0 #25035
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 fixes here come from better diagnostics in the latest Clang.
github-actions
bot
added
the
👀 pr-needs-review
crt0 is never compiled with this macro on in the first place.
This was a leftover from the times when CMake didn't support SerenityOS natively.
In addition to being rebased, LLVM driver no longer ever tries to link crti.o, crtn.o, or crt0_shared.o. The code that handles -pie / -static / -shared flags has been simplified as per MaskRay's suggestion (I made changes similar to llvm/llvm-project@ae623d16). Tests have been updated to match the current behavior of the driver. Note, however, that I didn't run them with non-default CLANG_DEFAULT_* options. The commit also removes Daniel's -fvisibility-inlines-hidden-function-templates patch since this functionality was never actually used and I feel like such features should either live in upstream or be deleted.
These files are always useless and are completely unused when our Clang driver is used to compile Serenity.
|
I looked through this and the only question I have is whether the patches were generated in the same way as the previous version? I think when I was hacking on this I would always use the same |
|
I think there's formatting difference because I messed up last time. I did |
ADKaster
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.