Cherry-pick "CSS: Add support for text-overflow property" #25061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
github-actions
bot
removed
the
👀 pr-needs-review
The CSS property "text-overflow" as well as its valid identifiers are added to the relevant json files for code generation (cherry picked from commit a8d3c077eabc8ae833db5dda38281b9103d9bb09)
This patch adds the new "text-overflow" CSS property to all the relevant places. (cherry picked from commit 794069b3cfb72b3e6a2c4068b6018a83d7d8432b)
The "text-overflow" property affects text that may get clipped if it is larger than its container and does not do any line breaks. The ellipsis character gets added to the end and the rest of the text gets trunctated if the property is set to "ellipsis". This patch implements this behavior in the InlineFormattingContext. :^) The "text-overflow" property is also added to the getComputedStyle-print-all test. (cherry picked from commit da7f0897d1eace887d75d966ffed6adde0e65196, amended to make `available_width` a float to fix -Wdouble-promotion from gcc. Everything `available_width` touches is float too.)
(cherry picked from commit e2c9e34050bd4c6fc6c653818cbb9e9a40ed5456)
github-actions
bot
added
the
👀 pr-needs-review
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LadybirdBrowser/ladybird#813